Skip to content

Remove Epoch helper class #1567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 13, 2018
Merged

Remove Epoch helper class #1567

merged 3 commits into from
Sep 13, 2018

Conversation

bording
Copy link
Member

@bording bording commented Apr 18, 2018

Now that we're targeting netstandard2.0, we can rely on the built in DateTimeOffset helper methods, ToUnixTimeSeconds and FromUnixTimeSeconds instead.

@bording bording requested a review from ethomson April 18, 2018 00:31
@bording
Copy link
Member Author

bording commented Apr 18, 2018

@ethomson I think something might be wrong with the AppVeyor setup. If you take a look at the details, it actually says one test failed, but it's still reporting everything as green...

@ethomson
Copy link
Member

I think something might be wrong with the AppVeyor setup. If you take a look at the details, it actually says one test failed, but it's still reporting everything as green...

Haha, that's delightful:

- ps: |
    Foreach ($runner in 'xunit.console.exe','xunit.console.x86.exe')
    {
      If ($Env:SHOULD_RUN_COVERALLS -eq $True -and $Env:publish_on_success -eq $True)
      {
        .\packages\OpenCover\tools\OpenCover.Console.exe `
          -register:user `
          "-target:""$Env:userprofile\.nuget\packages\xunit.runner.console\2.3.1\tools\net452\$runner""" `
          "-targetargs:""$Env:APPVEYOR_BUILD_FOLDER\bin\LibGit2Sharp.Tests\Release\net461\LibGit2Sharp.Tests.dll"" -noshadow" `
          "-filter:+[LibGit2Sharp]* -[LibGit2Sharp.Tests]*" `
          -hideskipped:All `
          -output:opencoverCoverage.xml
      }
      ElseIf ($Env:SHOULD_RUN_COVERITY_ANALYSIS -eq $False)
      {
        & "$Env:userprofile\.nuget\packages\xunit.runner.console\2.3.1\tools\net452\$runner" `
            "$Env:APPVEYOR_BUILD_FOLDER\bin\LibGit2Sharp.Tests\Release\net461\LibGit2Sharp.Tests.dll" -noshadow
      }
    }

Maybe the return code is not being bubbled up? I'll poke around with this when I have some time.

@bording
Copy link
Member Author

bording commented Aug 27, 2018

Re-ran the AppVeyor tests on this one, and they all passed this time.

@ethomson ethomson merged commit 321ac06 into master Sep 13, 2018
@bording bording deleted the remove-epoch branch September 13, 2018 15:24
alex-weaver pushed a commit to alex-weaver/libgit2sharp that referenced this pull request Mar 23, 2023
@ethomson
Merge pull request libgit2#1567 from libgit2/remove-epoch
0f83076 
Remove Epoch helper class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethomson ethomson Awaiting requested review from ethomson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bording @ethomson